Add QMEU to goreleaser #2936
Add QMEU to goreleaser #2936
Conversation
openshift-ci
bot
added
the
approved
awgreene
force-pushed
the
add-qemu
branch
2 times, most recently
from
432a179 to
69ba4c5
Compare
|
I've tested it here, binaries were built successfully, job failed due to missing credentials. This PR should be good to go. |
|
Left the experiment env var in, should have removed it. |
openshift-ci
bot
added
the
do-not-merge/hold
|
Works fine without the experimental env var. |
openshift-ci
bot
removed
the
do-not-merge/hold
.github/workflows/goreleaser.yaml
Outdated
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v2 | ||
|
|
There was a problem hiding this comment.
So, this is needed due to support different platforms, or??
There was a problem hiding this comment.
(Or to make docker happy?)
There was a problem hiding this comment.
Both. Right now the release workflow is failing because docker isn't pulling the correct image architecture and QEMU will help that.
|
/lgtm Probably out of scope for this PR - do we need this workflow to run on PRs at all? It looks like most of the steps are being skipped and only checkout, go setup Edit: updated the image with latest changes in the PR.
|
|
I agree with @m1kola that this doesn't need to be run on PR. /lgtm /appove |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit updates the goreleaser github action to install QMEU to support emulation of multiple architectures. Signed-off-by: Alexander Greene <[email protected]>
|
I'm assuming you did a rebase. |
No description provided.